Tony Xiang

@rtumac I just use string replace in the generated cpp files.

@mayeut Is this still relevant? I am thinking about to contribute on this. But I have doubts if the name of the repository itself needs to be changed. Otherwise you...

I wonder if we are creating static library anyway, why don't we just make `power_grid_model` core library itself a static library. We try to compile the header files in several...

> @TonyXiang8787 you mention that a sym/asym `current_sensor` should have `i_p_measured` and `i_q_measured`, which means the decoupling lies at the end-user. Wouldn't we in this case want to have `i_measured`...

> Implementation proposal step 7.ii: > > > 7. Make id optional in update dataset: in the main core, we need to have special treatment in is_update_independent to make id...

@mgovers I have reviewed and approved the PR. I am not sure if this should now be merged before `main_model` is ready.

@mgovers It is far from finished. I just put here to see what you think. The tap position optimizer, we still need to make it compile with mocked `meta_data`.

> how do you expect this to be extensible to columnar data format? or is this a first refactoring to make that possible in the future? because i foresee a...

@mgovers it's now ready for review

> > @mgovers it's now ready for review > > will have a look > > > ## [](https://sonarcloud.io/dashboard?id=PowerGridModel_power-grid-model&pullRequest=587) **Quality Gate passed** > > Issues  [18 New...