Patrick Müssig

`--nonfree` is in my opinion not the right name for it. GPL and LGPL allow you to earn money, but you have to grant access to the src. Maybe a...

> I used "nonfree" here because that is the terminology the GPL / the Free Software Foundation uses. Then we should use it, too. Most developers that have signed an...

> You five: Would you agree on adding a linking exception to our GPL license to allow interoperability with propreitary code (and NDA) like the Steamworks Library (Achievements & co.)...

is this a mac only issue or already fixed?

I've got this issue before are you using clang as a compiler? In my case, cmake uses clang as cpp compiler but linking only works if I select clang++. Maybe...

In ScriptMgr in line 314 is already a method `bool OnPlayerReputationChange(Player* player, uint32 factionID, int32& standing, bool incremental);` Is this good enough?

should `RepuationSource` be a enum or a real class, which contains additional information? For example the unit killed by the player?

I did some digging in the code from my understanding only `ReputationMgr` is used to call `ScriptMgr::OnPlayerReputationChange` what makes sense, however to extend the reputation Hook for specific quests/units it...

this functions need to get the information somehow. For example `Player`s `OnReputationChange` is called by the `ScriptManager::OnPlayerReputationChange`, which is called by `ReputationManager::SetOneFactionReputation` The other common used function is `SetReputation` however...

you are right, they already exist in `player.h` I was only looking into `PlayerScript.h`. I also found `Spell::EffectReputation` in `SpellEffects.cpp` Sorry I just realized you already pointed to right functions...