Tomi Saarinen

Common Mark compatibility?

1

Hi. Would it be a good idea to document what Markdown flavour does this library supports exactly. For example, I would like to know if this library aims to be...

Allow setting an 'alias' in bsconfig sources to affect import paths?

4

Having spent several unsuccessful hours trying to get a build working in a setup where we have some of the bs/reason source files in a symlinked folder, I figured I...

Implement adding event listeners for beforeunload

1

The intention is to enable using this browser feature: https://developer.mozilla.org/en-US/docs/Web/API/WindowEventHandlers/onbeforeunload There seems to already be a type for [Webapi.BeforeUnloadEvent](https://github.com/reasonml-community/bs-webapi-incubator/blob/master/src/Webapi/Webapi__Dom/Webapi__Dom__BeforeUnloadEvent.re), but not a attach an event listener for it. So this...

It seems to me the current [Dom.Image](https://github.com/reasonml-community/bs-webapi-incubator/blob/master/src/Webapi/Webapi__Dom/Webapi__Dom__Image.re) follows the spec of [ImageData](https://developer.mozilla.org/en-US/docs/Web/API/ImageData) object At the same time the actual [Image](https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/Image) object seems to be missing. If I'm right, that existing...

Moving memoized selectors outside of the component?

2

Hey, I'm writing this mostly to ask feedback and possibly suggest a new example on the web page. I've been slightly bothered by the fact that without something like the...

A line comment between function arguments breaks indentation when wrapped in another function

4

Like this ``` @react.component let make = React.forwardRef((~id: option=?, ~className: option=?, // Remove me to fix the problem ~children: option=?, forwardedRef) => { }) ``` Try it out here https://rescript-lang.org/try?code=AIJwpghgxgLgdFA9gWwA6IHZgzAUAGzBgAJkIBrMYgXmICVJY4AzREAdwhABMHmAKfgD8AltwBcxRKhgjMAHgDOMECIwBzAHzUA-ABpcQqPgiLFAOQjIwk6bIXLVG7ftwB6N-TDJEANyrWxDCIxMwiAB5BABZUqCCIAEaEyIZQUSL43OAYtjJyGPIM0PBgydgwLgasHFzcYLxgzACUNJrEAN64xMTy3CK+xG6auAC+TbhAA

I ran into this while using JSPM-cli that is apparently using this library, so this is more like a question/suggestion than an actual bug report. My original JSPM-related issue here:...

Hi @webarto. You have a nice library here. We've been using Instagraph lib together with [Imagine library](https://github.com/avalanche123/Imagine) which made me thinking. For the sake of having lesser and better libraries...

backgroundPositions should concatenate values without a comma

1

At the moment ``` CssJs.backgroundPositions([#right, #top]) ``` produces CSS ``` background-position: right, top; ``` I believe it should concatenate the values without a comma like this ``` background-position: right top;...

Without this, the package name will collide with the original ink package in Bower. In addition to merging this request, the package needs to be registered at bower.io Also creating...