Tom Sweeney

icon indicating an email [email protected]

icon company Red Hat icon location North Carolina icon location Working on containers for Red Hat. At home contained by wife and 3 kids, at least some of the time!

Results 216 comments of Tom Sweeney

server: remove exit file in exit monitor

LGTM assuming happy tests

Allow runtimes to be added and default runtime to be modified on config reload

The code LGTM for what you're intending to do. However, I'll have to lean on @giuseppe , @haircommander and @saschagrunert on the safeness of swapping out the runtime like this.

Manage ns: manage pid

Other than @saschagrunert 's comments, LGTM

Add bats test to measure goroutine stability

LGTM and happy green test buttons.

server: return already created ID for duplicated requests

LGTM assuming happy tests

server: update container status if state has bogus information

LGTM assuming happy tests

Inherit capabilities for container execs

One question, otherwise LGTM

Revert "Revert "server: use IsAlive() more""

LGTM assuming happy tests

Create /etc/sysconfig if directory does not exist

Code changes LGTM, I'm not sure what's going on with the tests, but there is an awful lot of red unhappiness there.

update drop_infra.bats

LGTM once the signature stuff is fixed up.