TomKlotz comments

Results 8 comments of


                                            TomKlotz

InitIndex method is returning SearchIndex rather than ISearchIndex

Hello! I've open a PR that I'll reopen when we will do a new major version of the client since this change is breaking. Because we cannot implicitly convert an...

Simplify rule comparison with equality function

Thanks for the work @aseure, Yes it seems a really good idea. I'll implement the changes once I found time. 🚀

Deep analyse the `HtmlSplitter::class`

I'm on it.

[Bug] scout:reimport moves index too soon, multiple race conditions

I'm taking this issues @nunomaduro

Refactoring needed in class `Algolia\ScoutExtended\Settings\LocalFactory::class`

it's a fix or a new feature for you ? For me it's just a fix

Refactoring needed in class `Algolia\ScoutExtended\Settings\LocalFactory::class`

My solution is to have an interface SettingAttributeInterface with one method(key,value,array)return array . Add for each different SettingAttribute class implements the interface then on factory call the object and their...

feat: bootstrap new testing strategy

It's awesome! Really nice work ! Just asking about the YAML request files : - Should we all have the YAML files in our repository or could we have a...

Add Splitter feature

Not for the moment sorry, it's still an open discussion. I'll update the status once we have more information. @nunomaduro