Timothy Jones

> Could this be fixed by removing the GITHUB_CLIENT_SECRET variable from the shim altogether and instead requiring that the service provider (i.e. Cognito) provides it? This seems like a much...

I no longer have access myself (I've moved positions since then), but I've sent the team a message. I know it includes other proprietary changes, so I'm not sure they're...

Update: We can get the relevant parts up on a branch here for you to experiment with. I'll try to make this happen this weekend. I don't have the time...

I can't issue granular permissions without moving the repo to an organisation. Would you be able to fork and make a PR instead?

@DannyDouglass I've pushed a new branch with the code from the private fork. Unfortunately, I didn't have the git metadata from it, so I wasn't able to do a proper...

> @TimothyJones I know this is an old issue but could it be that you forgot to add the `deploy-shim.sh` in your commit? > > https://github.com/TimothyJones/github-cognito-openid-wrapper/blob/workaround-2fa-bug/package.json#L22 @kujtimiihoxha Apologies, I missed...

@adam-nygate That's a good observation. It's possible this is related to overall URL length, as the shorter state tokens helped. I don't think there's anything in the shim that would...

I do know that code based on that branch works in a couple of production environments. I haven't included it in the main repository because it's extra resources and expenses...

@sambhavjain9138 I don’t know how cognito MFA works with federation, but I don’t think the question is in scope for this repo, I’m afraid. As far as I’m aware, federated...

Apologies, somehow I missed this issue when you opened it. I'm not certain whether Cognito uses refresh tokens with OpenID federation, so some investigation may be required. I don't believe...