Timo Glastra comments

Results 639 comments of


                                            Timo Glastra

Switch `BigInt` -> `bigint`

@feross could you please merge this PR? :) Thank you!

Nested generic with mapped types do not work

Still relevant

Nested generic with mapped types produce inconsistent results based on order of interface declaration

Still relevant

transaction endorsement uses %VER instead of the actual protocol version

Same with ``. Seems like a placeholder to me?

Cannot queue message for delivery, no supported transport

@sheraliinamdar I've also encountered this issue when using ACA-Py as a mediator with AFJ. I haven't been able to determine what the exact issue is, but have been able to...

Proposal: DIF PE v2.0 support in ACA-Py

Is the idea to support both v1 and v2 concurrently?

HTTP request hangs with return_route header

Wouldn't this be somehow expected? From the return route RFC: > For HTTP transports, the presence of this message decorator indicates that the receiving agent MAY hold onto the connection...

HTTP request hangs with return_route header

Just ran into this issue myself, so adding some info. @ianco it will never reach ``` return web.Response(status=200) ``` because a few lines above it waits for a message: https://github.com/hyperledger/aries-cloudagent-python/blob/31659902475de16118d8322f3cbc9c74f0b85ef5/aries_cloudagent/transport/inbound/http.py#L99...

HTTP request hangs with return_route header

Just ran into this issue again and after giving it some more thought, I now 100% agree with @smithbk. ACA-Py shouldn't keep the connection alive as this makes it impossible...

HTTP request hangs with return_route header

Made a PR to fix this. @ianco could you take a look at the PR? Mabye @smithbk you could verify whether this PR fixes your issue?