Florian Metz

Results 92 comments of Florian Metz

Okay I think I implemented it right now? Hope I didn't over-read something

@aklinker1 Anything about this, need to fix the docs now since that changed but everything else looking good?

> https://premid.github.io/Activities/v1/guide/best-practices.html#comment-your-code > > The level of commenting feels a bit over the top in the "good" example Updated, let me know if that's better

Highly doubt it because Discord hardcoded a lot of Spotify specific features that make things like clicking the cover art etc. link to the Spotify link

I like your abstraction approach, should've thought of that earlier tbh! ~~I need that brain of yours~~ I'll implement it the way you suggested it, I don't see any issues...

in the MessageTransport I added a `async close()` because for the port transport I have to close the ports I opened somehow on demand, for example if I use connect...

No worries, I lack a lot of time lately so that's fine... Also why I haven't done much on wxt

> Nice, I like it! Couple of questions: > > * Should `create` be named `update` or `reschedule`? Since `defineAlarm` already "creates" the alarm? > > * I always find...

Not quite sure how you'd design the api around it but might be nice to have the option to decide what happens, like either hook into an event and if...