Florian Metz

Results 92 comments of Florian Metz

There's actually a rare edge case that I need content scripts to not reload the page @aklinker1. For example if you want to test the behavior when the content script...

https://deploy-preview-933--creative-fairy-df92c4.netlify.app/guide/resources/migrate.html ![image](https://github.com/user-attachments/assets/d564c675-8e99-4e52-9d6a-43f9236dd234) Third checklist item is not at the next line

> I can retarget this to #1085 if you prefer. LMK! I think that would be better as @aklinker1 should be merging 0.20.0 very soon as he rebased everything from...

0.20.0 is released and out so make sure to rebase your changes on main!

> Can you add tests? Specifically making sure the minimal number of storage calls are added. > > Otherwise this is looking great! Thanks for adding this Will do! _Did...

> Now... I was reviewing the code, and noticed something. We already have some batch APIs: > > > > ```ts > > await storage.getItems(["local:installDate", "session:someCounter"]); > > ``` >...

> @Timeraa this is a big PR and your latest changes don't really match what I was asking for in this comment: [#990 (review)](https://github.com/wxt-dev/wxt/pull/990#pullrequestreview-2328292648) > > Would you mind if...

> Here's what my changes would look like if I updated the `getItems` and `removeItems` functions: https://github.com/wxt-dev/wxt/compare/batch-item-change-suggestions > > The setter and metadata functions will be more complex, I'm not...

Looking closer at it @aklinker1, wouldn't it make more sense if getItems returns an array of just the values since you can just use the array index since the order...

> Yes, but two comments: > > 1. That's a breaking change. Lets wait to do that until storage has been pulled out of wxt, and is a separate package....