Tim Kolberger comments

Results 8 comments of


                                            Tim Kolberger

Css style doesn't load as well in firefox 52 because of :host tag

The ChakraProvider has a prop cssVarsRoot where you can pass a custom css selector to which the css vars are attached to. Passing ":root" should have the same effect as...

feat(cli): add strict-token-types option to CLI

@lexanth yes, this is still a very valuable PR I'd love to merge. Kindly rebase it onto main. I'd like to test the change of the type `Token` in a...

Strict type tokens for other theme variables

> Would a strict generation mode PR be acceptable? Yes, I think this would be a great feature for codebases which rely on a strict design system. Love it 💖...

Reduce theme bundle size

v2 is only focused on React 18 support. We try to keep the breaking changes to a minimum to provide a smooth upgrade experience. Improved theme APIs are next up....

Prop definition of as-type not overwriting those of the component they are applied on → TypeScript Error

I forgot to update this issue. I experimented in the polymorphic repo, which is basically the extraction of the chakra as prop typings (chakra has still a similar implementation), to...

React TypeError: Cannot read properties of null (reading 'useState')

I created a reproduction for the original error with updated versions here: https://github.com/TimKolberger/issue-reproduction-vite-federated-modules I prepared the repo be easy to setup: ```bash git clone [email protected]:TimKolberger/issue-reproduction-vite-federated-modules.git repro-issue-294 \ && cd $_...

method ['delete'] still work when nothing provided

`Product.methods([ 'put' ]);` Same with PUT to Ressource path with no id passed.

Event type is lost when using `as` prop in React package

Thanks for catching that and providing a good reproduction 💖 When we remove the `ElementType` and narrow it to `as?: Default`, the event typings are correct again ✨ but another...