ThreeHrSleep
ThreeHrSleep
hey ! can I work on this issue?
please lmk if this format looks okay-ish or something needs to be changed(so I can replicate this with every opcode) ```{python} STOP = Opcode(0x00) """ Behavior: Halts execution Input: Output:...
Thanks a lot for the feedback! making a PR as soon as I'm done :)
Thank you so much for the suggestion @danceratopz ! On it (very sorry for taking so long :sweat_smile: )
update: almost done,will make a PR by tonight
really appreciate the detailed feedback !! starting to look into how I can go about building the tracing subscriber, will surely hit you up if I face any roadblocks :)
Thanks again for the feedback !! > Most of my suggested changes revolve around making sure we stick to display formatting vs debug formatting. - Trying to push all the...
> Tracing > > Slog Tweaked the formatter, here's what the logs look like now(as per the [suggestions](https://github.com/sigp/lighthouse/pull/6070#pullrequestreview-2199204855) ,tried to keep the format somewhat similar to what we had before...
> at the moment this is what a crit log looks like > > its labeled as `ERROR` but with an `error_type = crit`. Im wondering if we can tweak...
Apologies for the delay & for leaving that much mess in there. Thanks for fixing the stuff up! Dealt with whatever tracing-related TODOs were left , Let me know if...