Thomas Negeli

Results 8 comments of Thomas Negeli

@fballiano when you look at the network of your browser, you see that a minimum of Magento requests are PHP requests. Most of them are static content requests, which can...

what happens if you reindex via commandline, using the shell/indexer.php ?

Hi @YiffyToys, nothing special here. You just typed the package name incorrectly in camelcase letters. Composer package names are lowercase. Copy from here: https://github.com/ThomasNegeli/M2CliTools/blob/master/composer.json#L2

Hi @kanevbg, thanks for the improvement idea. Feel free to send a pull request.

E.g.: > $setup = $objectManager->get('Magento\Framework\Setup\ModuleDataSetupInterface'); > $mediaGallery = $setup->getTable('catalog_product_entity_media_gallery'); But don't use objectmanager for that.

@nahidacm what about introducing a parameter with the maximum amount of images to clean? Should be optional. max-files-count for example. You could send a pullrequest.

This is the default of Magento 2. So why would you use this module then?

This codepart is also not relevant if you do not have a subscription module in place https://github.com/mollie/magento2/blob/master/Plugin/Sales/AddRecurringData.php I think it would be better to move this code to the mollie/magento2-subscription...