ThomasGoulet73
ThomasGoulet73
Am I understanding correctly that the goal of this issue is for non-SDK style projects to use the same PresentationBuildTasks and Microsoft.WinFx.targets as SDK style projects ? IIRC, SDK style...
The code looks like it was never backported to .Net 8.0, it might be a mistake that someone confirmed it was fixed in .Net 8.0 RC2. The code in the...
Also WPF, like most of the .Net projects (dotnet/runtime, dotnet/winforms, etc), branch off of main before .Net 8.0 GA. Which means that PRs merged into main after this date will...
`OutputPath` is never used, it uses `IntermediateOutputPath` to get the path of the assembly to build in GenerateTemporaryTargetAssembly. The folder created at `OutputPath` is created by `PrepareForBuild` but from what...
@hughbe It seems like the only remaining point of discussion in this PR is about the removal of asserts, would it be easy to extract the tests that requires the...
@dotnet/wpf-developers The tests still fail to start even though it works in #7164 (Opened a day later). Maybe it's because my PR is opened from a fork ?
@dipeshmsft Could I get some info about what failed here ?
@dipeshmsft I don't think changing internal members should be considered as a breaking change. In my opinion, third-party shouldn't expect internal implementation to not change because then any changes become...
I rebased to fix the conflicts.
I rebased to fix the conflicts.