John

Results 25 comments of John

Hi @SemyonSinchenko , I think this two missions are relatively independent, the merge won't effect the decision about proto.

@Undertone0809 你好,我也想加入,请问可以发一个新的二维码吗?谢谢

# Support filter push down See PR. --- - Is compatible with Java SDK now: yes - The earliest released(or to be released) C++ library's version with this feature: v...

# Use inherit to implement EdgesCollection To fit this change: - Remove 4 supper classes of EdgesCollection; - Remove `create` function in EdgesCollection; - Write a new factory function in...

# Add internal id column to vertex payload file Remove one function and modify usage in test --- - Is compatible with Java SDK now: no - The earliest released(or...

# Refactor the C++ SDK with forward declaration and shared ptr The main point that may affect Java SDK is using std::shard_ptr to manage info classes, thus the usage and...

done ![image](https://github.com/apache/incubator-graphar/assets/119573640/7e9c4dab-1c63-4f2b-a65f-a48e7e212e04)

Hi, @TJxiaobao , I noticed that [this part of doc](https://hertzbeat.apache.org/zh-cn/docs/community/development#build-hertzbeat-binary-package) is under `zh-cn` but written in `en`. I can translate it to Chinese if this work is needed.

> I noticed that some interfaces in the Java code are not fully aligned with those in the C++ code. For example, the [Java code](https://github.com/apache/incubator-graphar/blob/main/maven-projects/java/src/main/java/org/apache/graphar/graphinfo/VertexInfo.java) is missing the `vertexInfo::getPropertyGroupByIndex` interface,...

> While writing unit tests, I found three issues: > > 1. Extra `/` in path concatenation(e.g. `"vertex/person//id/"`) (minor). > 2. Missing `getVersion()` in GraphInfo, VertexInfo, and EdgeInfo (may affect...