Han Kami 王

Results 11 comments of Han Kami 王

> thanks for the PR. Is it still WIP? If so, please add documentation and tests and mark this PR as WIP. See also some major findings do you mean...

@pierreprinetti @kayrus please re-review i am working currently working on the test case, hence the WIP

> This isn't adding tags to load balancer listeners, only to the load balancer itself. > > In my opinion we should allow tagging of all the LB resources being...

> This isn't adding tags to load balancer listeners, only to the load balancer itself. > > In my opinion we should allow tagging of all the LB resources being...

> Nice, this looks better! > > So according to Octavia API reference, the health monitors include tags [1]. I guess gophercloud doesn't support that yet, I'll look into that....

> Unrelated change, please remove. yeah i get you i will do that

i have made all the required changes to the PR @dulek

> Seems like you've used `security-group` instead of `security-groups`. I'm fairly sure only the latter works, but please prove me wrong if you've tested it and it works. > >...