Caleb Clarke

Results 86 comments of Caleb Clarke

> If you're still in contact with the WebKit devs Unfortunately I'm not, and I hadn't seen these issues you linked prior to the meeting. Which is too bad because...

This is due to a conflict between `react-native-popup-menu` and `react-navigation`. The example works because it does not use React Navigation. React Navigation registers its own `BackHandler` listener, and it does...

@asalha You can patch in https://github.com/instea/react-native-popup-menu/pull/205. If that doesn't fix your issue you might have a different issue.

I also use @react-navigation/bottom-tabs, but I'm afraid I don't understand what you're saying or how it relates to the pop-up menu.

@sodik82 I think this issue should now be fixed via #251 🙂

@sodik82 Are you still around? Could fix this be merged? Or were there concerns about it?

Oh dang I hadn't noticed those tests 🤦 I'll sort them out. (good on you having them and setting up the CI... so many GitHub projects are lacking in that...

Tests should be passing now, and added some new ones while I was there

Mm, good thinking, I admit that's not a use case of ours so I hadn't considered it.

Hmm. It might be. As long as it's reliably added/removed whenever menus are opened/closed so there aren't stray/duplicate handlers? (regardless of how the open/close was triggered) It's been a year...