Terry Guo comments

Results 8 comments of


                                            Terry Guo

How to remove - "Request may not be safe" warning for security providers ?

I am also running into this problem:

Support fuction reflect for wasm

Thanks Jaden. We will give your suggestion a try.

Restore the "Fold overflow intrinsics with select instructions"

Hi @akiramenai , what do you think of the score? They don't look good to me. For example, we got "Worst -19.108" for "Size All M3B3", I guess this means...

Restore the "Fold overflow intrinsics with select instructions"

> Overall the approach with a pseudo flag looks ok to me, but the tests imply that it needs to be addressed in some other places as well. I expect...

Restore the "Fold overflow intrinsics with select instructions"

> In order to fix this, we need to redesign how we are tying register in select instruction: > > 1. Remove all tie constraints from select instructions from `EraVMInstrInfo.td`...

Restore the "Fold overflow intrinsics with select instructions"

I searched the EraVM folder and updated the code to quit when need to inverse the `COND_OF`. The corresponding tests are added.

Use add!, sub!, mul! for overflow flag setting

Patch is updated to cover Vladimir's comments.

Redundant ADD after folding overflow

Same problem happens to #581 as well, for input IR like below: ``` define void @add_branch_neg_1(i256 %x, i256 %y) { entry: %res1 = call {i256, i1} @llvm.uadd.with.overflow.i256(i256 %x, i256 %y)...