Shenghua Chen

Results 8 comments of Shenghua Chen

@waitingsong No ,they doesn't work. ![image](https://user-images.githubusercontent.com/5396286/78331129-fcdc9180-75b7-11ea-9774-9af79157dfec.png) Looks like the type of the argument is not correct

Here is the code: ```javascript var { Kernel32, User32 } = require('win32-api') // import * as ref from 'ref-napi' const knl32 = Kernel32.load() const user32 = User32.load() // load all...

Hi @outofambit I called the GitProcess.exec() method to execute git stash push command as below: ``` let message = 'stash message' let args = ['stash', 'push', '--include-untracked', '--message', message] if...

I found my issue is similar to #174 , and my sign method is upload the binary to code sign server to complete the sign. Anyone can help? Thanks

Yes, you are right, it also works for .ts file. And it's working well in my project now. It was my mistake, I tested in the file that out of...

I got the same issue on LFS conflict. I found GitHub Desktop has resolution on text file conflict and binary file(non-lfs) conflict, but has no resolution for LFS conflict, hope...

I come up with a solution for this issue in this comment https://github.com/desktop/desktop/issues/8059#issuecomment-517353605 Could you give some comments on this solution?

@outofambit yes, you are right, we still need to implement LFS conflict detection I found when LFS conflict, the conflict file content will be a conflicted pointer file which contains...