Bruno Ploumhans

Results 555 comments of Bruno Ploumhans

I was going to open an issue for this, but realized this already exists. +1 for finding something better than `markDirty`, especially for block entities where it additionally fires a...

My 0.02$: `of` suggests a trivial operation, whereas `create` suggests a complex operation. For example, `List.of` is just a convenient helper. In Fabric API, I used `create` for `BlockApiCache` because...

Yes, `DefaultedList.empty()` might be more suitable here. Or it could be seen as the equivalent of using `List.of()` with no arguments... But in the latter case I think I prefer...

> -Now it inputs items then outputs items in separate tick, so it efficiently spreads out mspt. "Spreading out" doesn't make sense imo, it still uses the same amount of...

I really don't see why spreading out work helps? It reduces tps variance, but shouldn't change mean tps?

Sounds like it would maybe make more sense to allow these items to extract energy? Instead of bypassing an implementation detail?

![bikeshed](https://user-images.githubusercontent.com/13494793/106797966-9b64d380-665d-11eb-86d6-15230f6f2722.png)

So apparently the problem is that IF adds empty tags to items somehow.

That seems to make sense. Going to request the expert's comments: @TelepathicGrunt.