Andrei Ilinskii
Andrei Ilinskii
Whats wrong with Travis CI ?
Just tested it on Mac M1 and it works. I have patched hoster.py to make it works, i have replaced: ``` shutil.move(aux_file_path, hosts_path) ``` to: ``` shutil.copyfile(aux_file_path, hosts_path) ``` File...
I have thinked about my changes in code. It doesnt change anything, except adding MacOS support. shutil.move wasnt be atomic, cuz it different filesystems (hosts file is mounted), so only...
Also null coalesce operator can be used for shorter code. ```php return Cookie::create( $name ?: $this->defaultName, $jwt, $expiresAt, $path ?: $this->defaultPath, $domain ?: $this->defaultDomain, $secure ?? $this->defaultSecure, $httpOnly ?? $this->defaultHttpOnly,...
it only reproduces when php reads file. It doesnt fault with following code: ```
Hi @prolane, thanks for your work on PR #73. We’ve run into a concurrency issue related to the changes introduced there and would really appreciate your help in reviewing it....