Tal Zaccai

Results 39 comments of Tal Zaccai

> Hello, I would like to give this a go. This is my first time contributing so I will probably have questions. Go ahead! Please LMK if you have any...

> @TalZaccai I just had a question about one thing, then I will be ready to make a pull request. For the method in SetObjectImpl.cs, how should I access the...

> OK thank you. I created a pull request, what would the next steps be? If it's ready for review I'll go over it in the next few days and...

@tisilent My apologies, I think I misspoke with some of the previous comments I've had, now that I'm looking at similar command implementations. Let me take another look at this...

> @TalZaccai I have fixed the issue in NumUtil, where would it be better to add test cases. Good catch! Thanks!

> @TalZaccai Hi.arguments error Garnet: `ERR wrong number of arguments for 'LSET'` Redis: `ERR wrong number of arguments for command` ... I think it varies by the version of Redis...

> Please assign to me Looks like @tisilent already linked a PR. Thank you both!

> Few small nits for RESP writing/parsing parts, can be left as follow ups too. Much appreciated @PaulusParssinen! #Closed

> > Huh, `dotnet format` gives me nothing locally 🤔 > > @TalZaccai? @PaulusParssinen I am seeing dotnet format making changes when run locally... ![image](https://github.com/microsoft/garnet/assets/18443527/911a2497-3723-4551-866b-70d0ba46ca46)

> > ... > > That formatting seems unfortunate 😬I'm running .NET 9 Preview which may be the reason. Testing if I can reproduce it by downgrading. > > ```shell...