Tae Kim
Tae Kim
This is still an open question for me... after 7 years of development!
Spoke w/ @ljharb. Sounds like this is a reasonable approach with some tweaks (although the need to extend styles could be solved at a design level). The component would continue...
@ljharb @lencioni I've updated the API based on @ljharb 's awesome suggestions! We now tightly couple the extending styles function w/ the component itself. This update also simplified a ton...
I ran some performance tests to compare `master` vs this PR. My performance tests measured creating and rendering 10,000 components in various manners. There is a minimal perf difference between...
@lencioni Thanks for the feedback! I've worked with @monokrome on building out a plan for static analysis. I think the general gist is... - Similar to components that have a...
> If we end up using multiple classnames on the component, how will that work with CSS specificity and the ordering of styles? I think we take advantage of ordering...
> Can we find a solution that allows each module's styles to be self-contained? In other words if Button allows container.color to be extended, and BlueButton extends it to be...
I keep running into the same issue w/ specificity where psuedo-classes are overwritten (or not overwritten) based on ordering. I put together a fiddle to highlight my thoughts. https://jsfiddle.net/s7drg03k/5/ Are...
Will hold-off on merging until we can solve for static analysis. There are concerns around ordering of stylesheets for chunks.
Whew, I thought I was the only one! This was tripping me up all day. I'm glad someone realized it was based off reserved words! Here's my example to help:...