Szymon Kapała comments

Results 43 comments of


                                            Szymon Kapała

Causes build errors with Expo's EAS Build

Looks like problem with gradle/android.build.tools version.

Causes build errors with Expo's EAS Build

I think we need at least 4.2 `classpath 'com.android.tools.build:gradle:4.2.0'`

Async JSI functions with promises block the event loop indefinitely

It looks like you call that method from a different thread. I guess you should schedule that callback to JS thread with Jscallinvoker which if I remember correctly is keeping...

Missing subtle

@fitouch That would be great! Can you email us at [email protected] or me dirrectly [email protected]?

Fails to build for iOS in Expo EAS

Do you use expo-community-flipper by any chance? Looks for me that openSSL version is the problem here.

Fails to build for iOS in Expo EAS

Looks like flipper is the issue. Can you comment out the use_flipper line from your podfile and check it one more time?

[iOS][TextInput]Add numberOfLines and maxNumberOfLines props to TextInput on iOS

@sammy-SC @NickGerleman I just fixed CI Tests. Sorry for not noticing it earlier. Is there anything I can do to make the review easier?

[iOS][TextInput]Add numberOfLines and maxNumberOfLines props to TextInput on iOS

@NickGerleman @sammy-SC I know you have plenty of work and this pr may seems to be a bit complex at first but would really appreciate if you could take a...

[iOS][TextInput]Add numberOfLines and maxNumberOfLines props to TextInput on iOS

@sammy-SC I just merged recent changes on Main so there is no merge conflicts. I also added descriptions the pr so that you don't need to read original pr. Please,...

[iOS][TextInput]Add numberOfLines and maxNumberOfLines props to TextInput on iOS

@cipolleschi It's a pr that adds numberOfLines prop on iOS. Android and web already have that prop :)