Sylvia Whittle
Sylvia Whittle
Adding a test for the `.json` output is blocked by #653
No longer blocked by #653
There has been some debate about what format the files should be saved in, and if all traces should be in one file or multiple etc, and so I'm thinking...
Note to self: Make the heights and distances all in one JSON and change molecule index to a string "grain_54".
Would we prefer this over the arrays? It fills up more area in the config file, which we might want to keep looking less intimidating. It's a tradeoff between simplicity...
Thanks for your comments @Jean-Du , I've fixed the bug that caused the problem you found. It was a single minus sign.
> Looking to close up old issues that are lingering and I'm curious if this might be addressed by #666 ? This feature is slightly different. It removes grains whose...
Concept approved by experimentalists. Use max value. Users will be able to guess a good height to set as the maximum for their sample. Revive this PR
Added this functionality in the GetPlotData branch. It is complete however it is not currently needed in the main branch. Will need merging in the long term.
I'll do that now 👍