Songyang Zhang issues

Repositories
Issues
Comments

Results 2 issues of


                                            Songyang Zhang

Question about the input of regularizer

Hi Yulei, Thanks for your great work. When reading your codes, I'm confused with the following lines: https://github.com/yuleiniu/vc/blob/86e7712879964fd5d03f9412e6ed0b442bc3bd26/vc_model.py#L295-L296 According to your paper, the input of regularizer is z but not...

parent_id could be zero

I think the following line should be ```node.parent_id >= 0```, since the parent_id is 0 for whose parent is the root node . Am I correct? https://github.com/timniven/cstlstm/blob/f9af6842f05432ba70062e4f4cbee14328d2acdf/cstlstm/tree_batch.py#L161