Sven Widén

Results 12 comments of Sven Widén

> I think we should identify the source of the problem first... It seems like perhaps it's a difference between SDL & Macro schemas. > > SDL schema does correctly...

So I've started to dig into this a little bit. `import_sdl` in the schema notation works with the language definition structs running the draft protocol https://github.com/absinthe-graphql/absinthe/blob/master/lib/absinthe/schema/notation/sdl.ex#L16 which generates blueprint types...

> Alternatively, you can use `assertCustom` > > ```scala > object Name extends Subtype[String] { > override def assertion = assertCustom { str => > if (str.trim.size >= 1) Right(())...

> I would in general be wary of this because [corepack is being removed from future versions of Node](https://thenewstack.io/node-removes-corepack-bun-runs-native-c-from-javascript/). I don't know offhand what the best solution might be, but...

> Hi folks, what's the status on this? @huonw , could this be merged as-is? I've gotten stuck on other work unfortunately and I didn't manage to get all package...

I made some changes so we're able to run package managers on a specific version. I was unable to get it running for yarn so therefor the somewhat ugly fix...

@tgolsson how should I label the PR in order to fix the check [Ensure PR has release notes](https://github.com/pantsbuild/pants/actions/runs/11365342369/job/31625346939?pr=21523#logs)

> Oh no we just crossed PRs, see #126 But I will cherry-pick the suspend part from this. I removed the rbac stuff so that it is just the suspend/reconcile...

> The next release is likely to be 3.0.0 so could you target the `series/3.x` branch instead? Of course. Do you already have a planned roadmap for the `3.0.0` release...

> Thanks! Some minor comments below, although: > > 1. Is it possible to add a test for this or is it too difficult? Noticed that the [TextEventStream test was...