Tianlan Zhou

Results 33 comments of Tianlan Zhou

### u32toa ![1.png](https://i.loli.net/2017/08/14/5991a44b4a82d.png) ### u64toa ![2.png](https://i.loli.net/2017/08/14/5991a44cf37de.png)

@miloyip Would you please help me merge this pull request? :octocat:

@bigtimebuddy @Zyie Having any plan to review this PR?

> @SuperSodaSea we haven't lost sight of this PR. @Zyie and I chatted about it offline and feel like it's definitely worth getting in. I would like to get it...

@bigtimebuddy That make sense, I'll try to simplify the casting in the following days.

@bigtimebuddy I've removed most of the redundant casting, for examples: - No more `... as any` in the commited code. - Casting in `(... as any).addEventListener` and `.removeEventListener` is removed...

@bigtimebuddy I prefer Option 2, too. See 1a940982ca83b14d581695eb2e35fafd2d637a3d and de690ddc42a109ec635e59a826f41c1958809a34: https://github.com/pixijs/pixijs/blob/de690ddc42a109ec635e59a826f41c1958809a34/packages/settings/src/ICanvas.ts#L8-L33 https://github.com/pixijs/pixijs/blob/de690ddc42a109ec635e59a826f41c1958809a34/packages/settings/src/ICanvas.ts#L127-L137

@bigtimebuddy While changing `Extract.base64()` to an async method is simple, the `canvasUtils.getTintedCanvas` seems to be more tricky, since this method is used in synchronous rendering functions. What about your opinion?...

> I agree that converting canvasUtils to async is probably way too complicated. However, with the canvasUtils usage, I don't think we should be throwing here. I'd suggest this instead:...

@bigtimebuddy I've also prepared a PR for adding `@pixi/webworker` bundle (Fairly simple, I will create it after this PR is merged). Will it have any chance to be merged into...