Jasper van Brakel

Results 50 comments of Jasper van Brakel

> The Rust version is a compiler builtin, so it's not available to developers, only used internally. Also, the interfaces _are_ different, the Rust one returns a pointer. I guess...

I started working on this. It currently only does `weakref.ref`. And would it be better to be a separate module/file, since I currently put in `src/instance.rs` (Same place as `Py`)?

I've made a basic working version. Currently, `PyWeak` is a modified copy of `Py` and it only supports the basic Python `Ref` type. Some parts of the documentation still need...

A way to allow for `PyWeak` to be typed (3rd section), might be able to be achieved by creating are own `PyO3Weak` which needs to be statically typed, this can...

I (finally) had some spare time to add some of the features discussed. Currently, `PyWeakRef` (`weakref.ReferenceType`), `PyWeakProxy` (`weakref.ProxyType`) and `PyWeakCallableProxy` (`weakref.CallableProxyType`) are implemented similar to `PyList` in the new Bound...

There are some issues with the new `run_bound`. I will resolve these issues now.

> Thank you and sorry for the slow review, I will try my best to finally look at this tomorrow... No problem, completely understandable. I also ran into one last...

@davidhewitt, I'm running into an issue where code compiled with `abi-py37` does not enable `PyClass`es to be weakreferencable even if marked as so. It does work when compiling against Python...

https://github.com/PyO3/pyo3/blob/main/src%2Fpyclass%2Fcreate_type_object.rs#L311-L370 When compiling `abi3` on Python versions lower than 3.9 it does not write any offsets to the type object. Could this be the origin of the problem?

I think all the (current) feedback has been processed.