SunBlack

Results 51 comments of SunBlack

> For me: decades of experience with Make, versus an opinion that CMake scripts are inflexible and obscure. From my point of view CMake has a lot of benefits over...

> * not everyone cares about or likes IDEs, but you seem to be talking more about MSVC than about IDEs? Not only, but as this repo contains a `Makefile.msc`,...

@a4chet Your branch does not compile on Linux (e.g. your code: `#include "MBTilesDb.hpp"` vs correct `#include "MbTilesDb.hpp"`)

Is it possible, that is PR (and maybe the other) will be merged? Or is this project completely dead?

> @SunBlack could you please take a look at the OMP pragma sites? Took a while until both compilers build the branch. @kunaltyagi After removing Ubuntu 16.04 from Azure: do...

The idea behind dropping the old backend is to simplify the code by removing `#if VTK_RENDERING_BACKEND_OPENGL_VERSION < 2`, as I don't think any maintainer here really checks every relevant change...

@theoniko : Can you also removing all checks for `#if VTK_RENDERING_BACKEND_OPENGL_VERSION < 2` as you removed the sipport for this in CMake as well?

> > @mvieth , @SunBlack [ In Cmakelist under visualization folder ](https://github.com/PointCloudLibrary/pcl/blob/master/visualization/CMakeLists.txt#L231) do i need to update anything to this line? At first look, i do not think so but...

It's not this easy. Reason: Include directory is already added via FindCUDA script of CMake ``` function(CUDA_ADD_CUDA_INCLUDE_ONCE) get_directory_property(_include_directories INCLUDE_DIRECTORIES) set(_add TRUE) if(_include_directories) foreach(dir ${_include_directories}) if("${dir}" STREQUAL "${CUDA_INCLUDE_DIRS}") set(_add FALSE) endif()...

@modern approach: I know this variant. We are using it in our project, but it requires CMake 3.9, but we can only raise minimum version to 3.5, because of ubuntu...