StrikeW
StrikeW
> I quickly skim through the codes and I think the overall layout of the test suite looks good. Thanks for the PR. > > Before diving too deep in...
> After try_send_compaction_request is triggered, we can wait for some time (e.g. 5s) and poll both compaction task assignment and version delta. If none of them has changed, we are...
> Will the test tool still work if we restart the whole cluster (without cleaning etcd and S3) after data loading is done? Yes. And we need to restart the...
> > > I think we can keep the assumption of 2 static compaction group in the first version of compaction deterministic test tool, if it requires lots work to...
Please withhold this refactoring, especially the `CompactionRequestChannel`. Because the compaction testing tool which I am working on relies on existing mechanism. In short, I will use a mock channel to...
It is not easy to discuss the changes I have made to the compaction scheduler here without code. I will submit a draft PR on Monday, then you can check...
Would you mind adding some background of this PR? Why do we need to `upload all data to shared storage as a sstable`?
Any progress about caller hierarchy (**Call Hierarchy** in Clion)?
IMO, this feature is very useful. PTAL? @vlad20012
I encounter the same issue. @adambezecny 's solution works for me. Thank you.