Steven Dufresne

Results 181 comments of Steven Dufresne

The theme review action does use the same JS parse function that Gutenbergs does to check for block templates in a very similar manner to what @fklein-lu mentions. https://github.com/WordPress/theme-review-action/tree/trunk/actions/ui-check/tests/unit/block-templates

I think [Sandpack](https://sandpack.codesandbox.io/docs/) also uses CodeMirror.

I opened #13 not sure if it made sense to add it here. Thoughts?

> **system3** -A user can only submit a complete theme > This is covered by checking that the required files are included, > > * Names cannot be “reserved” for...

@carolinan Apart from my last comment, is this the final list of checks? Have they all been validated and agreed upon?

I've moved Structure11, Structure12 to the distribution list. I left the ids as is. [Edit] Moved Structure1, Structure10 to "safe". We'll need to move to numberless & category-less ids in...

Here are my thoughts on: `Associate the correct tools to the correct parts`. ### System Checks Tool: [class-wporg-themes-upload.php](https://github.com/WordPress/wordpress.org/blob/master/wordpress.org/public_html/wp-content/plugins/theme-directory/class-wporg-themes-upload.php) This should continue to run its checks, which I documented in #13....

> **I am still hoping that we can find more ways to reduce the requirements.** > For example, the screenshot size and ratio requirements could be a fix for the...

This is due to the `PWA` plugin not being enabled on install.

> I think the main reason for that is that the majority of Meta committers (myself included) don't use it as their daily environment Great point! If you find some...