Stephen Barlow

Results 10 comments of Stephen Barlow

Hm, currently it's challenging to pick out the parts of this PR that differ from the AS3 docs, versus what's just being re-added verbatim. Other reviewers might have a thought...

@trevorblades Can we add arbitrary metadata to the opening line of a codeblock as shown above? Or do we have special rules in place for the types of metadata we...

@JakeDawkins Regarding version availability, I recommend a little blockquote notice immediately after the feature in question is mentioned, such as: ``` > Support for linking _multiple_ local schema files is...

Hi @Barrosg99, I believe you might have put a `!` in the incorrect spot in your `bookTrips` schema definition? This is the definition as written in the "Build a schema"...

Hello, thanks for reporting! You can indeed provide these values to the `ApolloServer` constructor via the [`apollo` option](https://www.apollographql.com/docs/apollo-server/api/apollo-server/#apollo). You've pointed out some definite omissions in the docs (including a warning...

All directive descriptions have been removed from this doc in favor of the "Federation-specific directives" article, so I'm going to recreate this content targeting that article in a separate PR!

@dariuszkuc @patrick91 Thanks for all the thoughtful feedback! I've updated the PR with one squashed commit-of-commits, so the diff since the last review should all be straightforward here: https://github.com/apollographql/federation/pull/2045/commits/67d774314989ec3ed7481d6a9414e160f9c068f5 Hopefully...

@dariuszkuc Pushed a followup commit that hopefully addresses remaining feedback! https://github.com/apollographql/federation/pull/2045/commits/d150fadf9e607e44e9df2c765d42de8f266d5ee9 It also folds in `@composeDirective`, which was added to the subgraph spec while this PR has been open. Does...

We've updated [the docs](https://www.apollographql.com/docs/federation/federated-types/composition/#enums) to correct this error in describing enum composition logic. Apologies for the confusion!

@clenfest Lookin' at some older PRs with docs involved. Are these `@link` changes true _now_, or is this part of potential future change?