Contrail
Contrail
@martincpt Your pull request seems to address the open issue #116. Perhaps it would be nice to link to the issue? I would also like this pull request to be...
Thank you for your reply. I think 'Close' would be nice.
Lint fix also included, so all checks can pass before merging.
Second this. Weaviate v1.24 and later supports GSE and trigram tokenization, which (I hope) significantly improves the accuracy of Japanese and Chinese keyword searches.
Thanks for the review and for raising that point. Since it’s impractical to test against every possible provider, here’s my reasoning: - The change lives entirely within the QuestionClassifier’s `_run`...
@laipz8200 Thank you for the feedback. The real issue isn’t with `_fetch_prompt_messages` alone, but with how it combines with `_get_prompt_template` in the Question Classifier both add a user message, causing...
If there are still concerns about this change, I’m okay with closing this issue and PR for now. I think the most important thing is that everyone is comfortable with...
@laipz8200 I’ve added a comment in the code to explain the reason.
Given vLLM’s popularity, I imagine this fix is highly requested. If a fix is underway, could you let me know when it will be released? Thanks!
Hi @crazywoola, thank you for the quick response! The issue still persists even after switching to yangyaofei's vllm plugin, so I'll go ahead and open a new PR! > [vllm]...