StefanBalt

Results 7 comments of StefanBalt

I also added a second commit where I add the const qualifiert to the FF_IsNameCompliant() argument. This fixes a -Wdiscarded-qualifiers warning.

> 1. How often is mallinfo called? Is this really worth adding code to optimize? I do not know why `mallinfo()` should be relevant as only `sbrk()` is changed. >...

Ah youre'right the Zynq7000 port uses `XEMACPS_NWCFG_MCASTHASHEN_MASK` directly instead of using the API function. I added the discussed multicast fixes to the Zynq7000 port. I noticed the promiscuous mode in...

Sure, I will push a fix (probably today).

> I don't have the time to test it, I hope you did. As mentioned earlier, I tested some of the features but not all (i.e. IPv6, DHCP and more...

> [EDIT: @StefanBalt] Your `xPortGetMinimumEverFreeHeapSize()` implementations appear to be incorrect. I acknowledge that the current `xPortGetMinimumEverFreeHeapSize()` implementation provides only an upper bound rather than the exact minimum value. This approximation...

I just stumbled upon `__malloc_max_total_mem` (alias `max_total_mem`) used in `mstats()` among others. See here: https://github.com/bminor/newlib/blob/newlib-3.3.0/newlib/libc/stdlib/mallocr.c This may be a much better choice. This variable hold the maximum memory ever sbrked....