Doyung Yoon
Doyung Yoon
@djfwan can you elaborate more on errors? can you provide error log or Exception type?
@emeth-kim: can you give us PR for this? otherwise I will be working on this this weekend. also quick question. do you think only weighted sum need to be supported??...
@djfwan: can you provide PR for this issue?? since seems like you already go through necessary codes
@daewon plz review this, then I will update apache jira once we discuss the direction we should take for massive code changes.
Currently there is three point that I think cache can help on query path. Query structure follows below. Query consists of multiple step, and each step consists of multiple queryParam....
I was working on this issue and figure out that we don`t need to restrict cache implementation for result cache to local cache. maybe remote cache like memcached or redis...
problem with this bug is hard coded value for isInnerCall for public method on query builder. https://github.com/kakao/s2graph/blob/develop/s2core/src/main/scala/com/kakao/s2graph/core/storage/hbase/AsynchbaseQueryBuilder.scala#L230 easy fix would be just change isInnerCall = true to isInnerCall = false.
@elric-k : are you still working on this issue? if so, can you PR what has been done so far with descriptions?
@elric-k : what about when group by clause is given?? should we return 10 groupby key? or each grouped collection should return 10?
Not quite finished yet. I think we need to refactor code and change Cache Trait as following. Key: QueryRequest Value: Seq[QueryResult] also I think Cache Trait should contains following methods....