Sparsha Saha
Sparsha Saha
@kelset sure I can submit a PR but before I did that i wanted to confirm if you folks also think that this will be a meaningful addition.
Yeah. Makes sense. We can maybe add "types" as a capability. If "types" is listed as a capability, the tool will check/include typings for required packages. What do you think?
@cortinico I see. Do you suggest that we add this as a cppFlag in build.gradle under `externalNativeBuild`?
@cortinico I am not sure if NDK toolchain would automatically set the stack-protector flag by default because adding that flag might cause a size increase and might impact perf negatively...
Hi @cortinico , I am also being to repro the same issue on React Native 0.71. Do we know whether react native 0.72 fixes this problem? If so, can we...
Just FYI I think we can do this much easily even without using rz-bin. Steps below (MAC): 1. Extracting an apk using any archiver (I personally rename the extension to...
@cortinico let me check that.
@cortinico @kelset @dragorwyin I downloaded `ReactAndroid~0.72-rc6` from maven and it looks like the following `.so` files are still not stack protected. libreact_config.so libreact_debug.so libreact_render_debug.so libreact_render_telemetry.so libreact_utils.so libruntimeexecutor.so
These not-stack-protected .so files are common for all architectures (arm68-v8a, armeabi-v7a, x86, x86_64).
@cortinico @kelset @dragorwyin this PR: https://github.com/facebook/react-native/pull/38018 should solve the stack_chk_fail part of this issue.