ghost43

problems making appimage reproducible

20

I am trying to make the [AppImage binary for Electrum](https://github.com/spesmilo/electrum/tree/03ab64e39f210f16ac8419974c67eea03a19da6c/contrib/build-linux/appimage) reproducible/deterministic. Looking at e.g. https://github.com/AppImage/AppImageKit/issues/625, I take it this should be possible. I am using [appimagetool release 11](https://github.com/spesmilo/electrum/blob/03ab64e39f210f16ac8419974c67eea03a19da6c/contrib/build-linux/appimage/build.sh#L32). I think...

Activity lifecycle issues. after onDestroy, application will become unusable

15

I am testing [latest Electrum](https://github.com/spesmilo/electrum/commit/5c83df7709505ddde9584cd9de1ce2c614292a3a), which uses p4a https://github.com/kivy/python-for-android/commit/ccb0f8e1bab36f1b7d1508216b4b4afb076e614f, buildozer https://github.com/kivy/buildozer/commit/678b1bf52cf63daa51b06e86a43ea4e2ea8a0b24, and kivy https://github.com/kivy/kivy/commit/82d561d62577757d478df52173610f925c05ecab (sdl2 bootstrap) on both Android 8 and 9 If the application is in the background, and...

ctypes.pythonapi issues; getting AttributeError: undefined symbol

12

Using the new python3 toolchain, I am trying to use PyCryptodome (3.7+) as a dependency. As in https://github.com/kivy/python-for-android/pull/1685, PyCryptodome >= 3.6.4 runs into compilation issues; I am trying to fix...

Known regressions since network-rewrite

5

A very large chunk of the networking code was rewritten recently, using asyncio and aiorpcx. This introduced some regressions: - [x] merchant websockets are broken - being addressed in https://github.com/spesmilo/electrum/pull/4753...

`add_request` command used to reuse addresses of expired payment requests but not anymore

1

The `add_request` command prior to version 4.3.0 used to reuse addresses that correspond to expired payment requests (but are otherwise unused). On current master however, it now returns False (unless...

protobuf breaking changes between 3.20.x and 4.21 (4.x)

1

Google made breaking changes in protobuf (see e.g. [here](https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates)), in the generation and parsing of `_pb2.py` generated files. Re the python [`protobuf` package](https://pypi.org/project/protobuf/#history), the 3.20.1 release is followed by the...

Allow selecting custom fees for LN channel open (funding tx)

2

Currently when opening a channel using the Qt GUI, the user can only use the fee slider to select a feerate for the funding transaction. We should allow entering arbitrary...

This is most useful if the user wants to import a significant number of keys, as every invocation of `importprivkey` results in rewriting the wallet file to disk. The API...

Electrum 4.0.5 AppImage reproducibility issue (kerberos, git)

2

When building `electrum-4.0.5-x86_64.AppImage`, ThomasV and I got the same hash, however [travis got a different one](https://travis-ci.org/github/spesmilo/electrum/jobs/744499481#L2511). ``` 54dd4cdb42fe967eb9c3454ef45b1bd35b281475d4a15e5582a911e3d671d2a5 electrum-4.0.5-x86_64.AppImage_offi 31965018e5574248c9596c7f5e39fa0f345e607592b26efc087edce7842eb0a7 electrum-4.0.5-x86_64.AppImage_travis ``` ``` $ cd dist/ $ ./electrum-*-x86_64.AppImage_offi --appimage-extract $...

lnpeer: async `maybe_send_commitment`

1

this builds on top of https://github.com/spesmilo/electrum/pull/7835 (first commit is from there) This is re https://github.com/spesmilo/electrum/commit/cc1b4a5c903ac82d20d8107f45d829d8d1270a80#commitcomment-74922012 > - Await pong before sending commitment_signed (per BOLT-2) We `await self.ping_if_required()` inside `maybe_send_commitment()`. This...