Illia Bondar
Illia Bondar
For me it just does the job of storing degrees for each axis 😅 Though I understand what you mean Would you prefer a new class that would store 3...
Made a test version, open to suggestions. `Rotations` could be a record in theory, but I'm not 100% on this.
Should be ready now. Namings/javadocs can be tweaked if needed.
> I’m curious what was the reasoning behind adding an entirely new type rather than just doing something like a new utility method? Because at least currently it doesn’t look...
> make `Rotations` an interface with a private inner record implementing it I suppose you meant package-private implementation since it's not possible to have an inner private record inside the...
> Might be a little late, but any reason why we use doubles instead of Floats? Minecraft uses floats for armor stand rotations. Just for ease of use. No need...
There's not much that NBT-API can do. The bug here is that both items share the same exact nbt tag objects despite the cloning operation. So when NBT-API modifies the...
> I'm honestly not sure on introducing an inherent performance hit on API which already has its issues, and behavioural change, especially when the primary way of exposing this behaviour...
While Configurate is neat, I doubt NBT-API 2.x would benefit from it. Shading it into core would add a few extra hundreds KBs for something that the majority won't use....
Made a simplified version that fixes `ItemStack#clone` by cloning unhandled tags inside `CraftItemMeta`'s constructor. `ItemMeta#clone` will still have this issue, but it's less of a load and mess for already...