Kacper Sokol

Results 29 comments of Kacper Sokol

![](https://github.trello.services/images/mini-trello-icon.png) [As a *developer* I want the *code* to be continuously *tested*](https://trello.com/c/XytYPFty/8-as-a-developer-i-want-the-code-to-be-continuously-tested)

I think you're right. `.pytest_cache/README.md` says that none of the files in the `.pytest_cache` directory should be committed to version control so we need to add this path to `.gitignore`....

If all the remaining lines use `os.path.join`, we won't need [lines 1213 and 1214](https://github.com/honeynet/cuckooml/blob/2e5c87e98daeae43c0f560611cb6645b62f4ec92/modules/processing/cuckooml.py#L1213,L1214) as it will be already taken care of by `os.path.join`.

It's not about path separator in the end, it's all about concatenating file paths in robust way. When I was writing the code I knew exactly where the path will...

Sorry but I don't really have time to walk you through the issue; I'm quite busy right now so I can only review the code and comment on it. For...

Great! Before you do a PR please send me a link to you commits and I'll have a look at them.

@greninja, linked commit does not exist.

Comments attached to your commit.

Not really, given that we want to automatically analyse large malware datasets this could potentially cause inconvenience. A better approach would be to give one plotting switch in `conf/cuckooml.conf`, but...

At the moment they are all imported in one block. For instance `pandas` is necessary for the module to work, but `matplotlib` is only needed if you want to plot...