Smithx10

@petemounce I think its important for visualization over time that the operator can discover what goss check failed and when. The format in PR https://github.com/aelsabbahy/goss/pull/175, looks like it would provide...

@aelsabbahy, Currently I have something basic working with the prometheus client. https://github.com/Smithx10/goss/commit/b336a7e146843393f4a5266495cf62525f2ae131 I'd like to have the metric name be based on the resource type, but couldn't figure out how...

I'm thinking of creating a prometheus collector instead in order to get similar metric names like @pysysops has. Hopefully i'll get some time and figure it out.

@pysysops , I'm not really using goss as a tool for health checking applications, because I really don't believe that's the ethos of the project. All I, as a Prometheus...

I decided to give this branch a test since I have a bunch of NVME pools and would love some performance increase. I ran a read test with my 10...

I also noticed that you can't set direct on a zvol. "cannot set property for 'test/foo': 'direct' does not apply to datasets of this type". Do zvols suffer from the...

> > I decided to give this branch a test since I have a bunch of NVME pools and would love some performance increase. > > I ran a read...

Adding #define _XOPEN_SOURCE to cstore_fdw.c got me to: ``` [root@tommy-dd378711 ~/cstore_fdw]# make gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -pipe -O2 -D_FORTIFY_SOURCE=2 -I/opt/local/include -I/opt/local/include/ncurses -DLDAP_DEPRECATED -I/usr/include...

Turned out you only need to add -D__EXTENSIONS__ to the Makefile. Could this be merged?

Seem's relevant https://www.illumos.org/issues/6283