SlugFiller

Results 115 comments of SlugFiller

Okay, I hit a problem. In order to take on execution `UserScriptContextMenuExtensions.AddUserScripts` needs to take, as a replacement to `Action scriptInvoker`, an `IScriptHostControl`, a `Control` (for `Control.FindForm`) and a `IGitModuleControl`...

For the time being I implemented option 5 in #11273. Can easily change to the other options later.

If you read the discussion in that PR, I've already implemented a better solution, where `IScriptHostControl` carries the necessary parameters, avoiding the need to pass them another way. I've also...

The MVVM might not be necessary, but #11279 _is_ necessary, because passing a method around instead of just using an event makes for all sort of complications. See [here](https://github.com/gitextensions/gitextensions/pull/11273#discussion_r1361134225) What...

I can't figure out why AppVeyor is failing. It's not specifying a failed test. Running `dotnet test` locally causes some complaints about `AsyncLoader`, but the tests are all passing. I...

Hmm. Managed to reproduce it. If I open the commit dialog, run a script on a file that opens a `Process` window (Doesn't happen if done on a background script,...

Rebased to use `IScriptOptionsProvider`. Needed to de-unify `IScriptOptionsProvider` from `GitModuleControl`, so the commit dialog can provide options based on whether the menu was opened (or hotkey was pressed) from the...

> Do hotkeys assigned to scripts, work in the tabs "Diff" & "File tree"? Yes, this is what the changes to `GitModuleControl` (and `GitModuleForm`) are for. When a hotkey is...

Okay, rebasing started being a mess, with commits reverting previous commits, forcing a double merge of the same changes in both directions. So I squashed it. The rebased version matches...

Had to rebase again due to conflict (Minor change in an deleted line)