SlugFiller

Results 115 comments of SlugFiller

Since another topic was marked a duplicate of this, I'll repeat what I said there: First, since the issue is in just this one (non-critical) file, there should be a...

@dyaricoderman Hmm, 9 on yours vs 4 on mine. I triggered "Google", though, which is not on your list. My build was a bit unusual, though. I'm not a fan...

@dinkumoil Yes. It shows a tiny unreadable version of the document while hovering over the tab with the mouse. It has nothing to do with switching, and certainly isn't helpful...

> I wish you've indicated your desire to work on this so that we could discuss the approach and the implementation. The time between me posting this PR and you...

> I think the new file options do not need the prefix "f". "c" stands for the **c**urrent / **c**hecked-out commit in contrast to "s" for the **s**elected commit. And...

> The prefix "f" does not have a meaning for the user. There will be no "gSelectedFiles". So it should be omitted. There might be "fs", if there's popular request...

I tried rebasing, but hit a snag: In the current `master`, whenever I open the settings window, I get an exception here: https://github.com/gitextensions/gitextensions/blob/a0d8a30c79ba54e5b231786f46d381b96c584955/GitUI/CommandsDialogs/SettingsDialog/Pages/ScriptsSettingsPage.cs#L124 I can push the rebased version anyway,...

Pushed anyway, because `dotnet test` passed, and it's better than a version with conflicts. Changes: - Rebased - Removed `f` prefix - `s` and `c` prefix options will only generate...

I'll try to make a tiny "Remove `IRunScript`, replace with `IScriptHostControl`" PR, and then rebase this PR on top of it.