Garand Tyson
Garand Tyson
> I'll squash this later, but for ease of reviewing, I [changed the semantics](https://github.com/stellar/stellar-core/pull/4178/commits/0b22c56a1057e1cc134fe3a39a59e329fee26217) of `LedgerKeyMeter` slightly: > > * If a key is not in the footprint of any...
Closing, invariants in SQL were buggy
It looks like Soroban TXs (Restore, Extend, InvokeHostFunction) don't prefetch any keys. For SQL, this makes sense. We prefetch all keys in a single query, so there is no way...
I've now added a batch load endpoint called `getledgerentrybatch`. This is a POST method and requires the following body: ``` ledgerSeq=NUM&key=Base64&key=Base64... ``` `ledgerSeq` is an optional value that follows the...
> Additionally, how can I distinguish TTL'ed entries? Are TTL'ed entries the ones with `"dead"` status? > > I will need the entry for those as well. If an entry...
> What is the maximum number of ledger entry keys this endpoint could accept? I haven't tested the maximum entries for a single query. However I doubt it will be...
> LGTM, could you please rebase and squash? Done
All your comments should be addressed @Shaptic
> I also was wondering if you considered a version that doesn't have the "populated" flag, but that returns an optional from the populate function, i.e. treat it as a...
I've run some more tests on larger topologies of about 100 nodes (tier 1 + some watchers) and saw a modest improvement of about 200 ms of average block time....