SimonVrouwe

548dd09 fixes pip error: `pytest-xdist 2.2.1 requires pytest>=6.0.0, but you have pytest 5.4.3 which is incompatible.` when installing `requirements-dev.txt`, because `pyln-testing-0.9.3` needed `pytest-5.*` after 548dd09 and `python3 -m pip install...

`test_drain_and_refill` fails on this, not raising an error: https://github.com/lightningd/plugins/blob/22923724a99ff2a1d92f753b32b37cd1f0b224a9/drain/test_drain.py#L66-L70 Initially I thought maybe `option_zero_htlc_tx_fee` got activated, making above not raising the error. The test start failing at commit [0aad222c2](https://github.com/ElementsProject/lightning/pull/4972/commits/2202a68d032e78fe9ea931dd7ec103b95cdc52e7) in...

@cdecker I think this is ready for review/merge (if desired). The failing integration tests is not caused by this PR, see above.

Rebased on master, not sure what the mergify rebase did. Only added two commits, to address type safety and make it easier to review (I hope!). > Wouldn't it be...

Thanks a lot for the explanation. > Making the response asynchronous would just mean that we pass the request object to compact() > In your case we'd simply pass the...

> > > Any chance we could keep the compact() method agnostic of being run in a thread or on the main thread? > > > > Yes, just lock...

Rebased on latest master (nothing else). There always appears to be some problem with the testing system, this time a network error? ``` Collecting pip WARNING: Retrying (Retry(total=4, connect=None, read=None,...

> Traceback (most recent call last): File "/root/repos/plugins/backup/backup.py", line 2, in from pyln.client import Plugin File "/root/repos/lightning/contrib/pyln-client/pyln/client/__init__.py", line 3, in from .gossmap import Gossmap, GossmapNode, GossmapChannel, GossmapNodeId File "/root/repos/lightning/contrib/pyln-client/pyln/client/gossmap.py", line...

Fees are pretty low lately, so low fees that should not be a problem. I am not sure if `lightningd` keeps trying to broadcast the funding transaction forever. Maybe check...

Nice catch. > It appears the test was intended to only mine 100 blocks originally, but had an accidental copy-paste in it. I think both lines `bitcoind.generate_block(100)` are obsolete and...