SidharajU

Results 7 comments of SidharajU

Updating saimacsec.h to add macsec_port_id to flow obj

@dipankar-ba @lguohan Please review

Updating saimacsec.h to add macsec_port_id to flow obj

In the current implementation (without the proposed changes), there is no relation between secure flow, secure channel and the macsec_port_id/port. MACsec user is not able create a flow or secure...

Updating saimacsec.h to add macsec_port_id to flow obj

> please add PR description I have added comment about the description: In the current implementation (without the proposed changes), there is no relation between secure flow, secure channel and...

Updating saimacsec.h to add macsec_port_id to flow obj

> This change does not allow using a MACsec flow for multiple MACsec ports. Instead of binding a MACsec port to a MACsec flow, can a MACsec port be bound...

Updating saimacsec.h to add macsec_port_id to flow obj

So are we moving back the MACsec port id from MACsec SC to Flow. There is already an implicit relationship between MACsec port -> ACL table -> MACsec flow ->...

Updating saimacsec.h to add macsec_port_id to flow obj

Thanks Dipankar. @helloanandhi Are you okay with the current changes based on Dipankar's explanation?

[EXTERNAL PHY] Clarification needed on SAI_PORT_ATTR_SUPPORTED_FEC_MODE and SAI_PORT_ATTR_SUPPORTED_FEC_MODE_EXTENDED attributes

Based on today's discussion in the OCP SAI meeting, its best to return all supported FEC modes by the chip. In certain cases, supported FEC modes should be known to...