Katherine Miller

Results 5 comments of Katherine Miller

changing the definition: ```cpp template using return_type = decltype(regex_results(std::declval(), find_captures(Pattern{}))); ``` to ```cpp template using return_type = decltype(regex_results(std::declval(), ::ctre::find_captures(Pattern{}))); ``` fixes this issue

Actually the equality comparison would just be ```cpp return impl_.template equals(other.impl_); ```

oh yeah `key_set` is fine. how would that work for values though? keys have to be unique but values don't, how would that work with the shared implementation? you'd be...

I wasn't able to do much past just disabling moves for `whole` in the case where it has a value...

the signature also only accepts variant rvalues: https://github.com/felixguendling/cista/blob/99b4f5cdad1c54175078d636ff7f3a4133df3902/include/cista/containers/variant.h#L442