Simon Adcock

Results 40 issues of Simon Adcock

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of...

## What is the purpose of this change? There are compelling reasons to dogfood our own ESLint plugins: - ensure Source is conforming to the standards and rules we place...

By default, `` elements have a [role of `group`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset#technical_summary). Updating the `role` to `radiogroup` adds extra information that screen readers can convey to users.

**Describe the bug** In IE11, a multi-column tile layout looks like a collapsed stack with no margin between tiles **Expected behaviour** Do we could just say that a tile layout...

Layout
Internet Explorer

This is a central issue for any bugs relating to form field validation. This may include: - error styling and when it does and doesn't get applied - form submission...

bug

**Describe the bug** I get a lot of use out of opening a canvas in a new tab. However, I find that args are not passed to the component in...

bug
has workaround
core
args
addon: controls

The dev workflow of [running DCR alongside frontend](https://github.com/guardian/frontend/blob/158983cced9e6220ad73b1b1c3eb90fa6e123be0/docs/01-start-here/01-installation-steps.md#running-frontend) is currently broken. We are attempting to load JavaScript assets from the wrong place, so JavaScript doesn't get loaded in this scenario....

Bug
Pick me up
Rota

## What [These tests](https://github.com/guardian/csnx/tree/main/libs/%40guardian/libs/cypress/e2e/consent-management-platform) are the only Cypress tests in CSNX. We should convert them to Playwright. ## Why - fixes compatibility issue concerning Jest and Cypress tests. Currently we're...

# ISSUE When the task runner encounters an error (e.g. `scalafmt` detects formatting issues), it falls over with a JavaScript error, and doesn't print the helpful error message telling the...

We use this in several places ([InstagramBlockComponent](https://github.com/guardian/dotcom-rendering/blob/cfb471804222b2b617609bff97386a9eceb59922/dotcom-rendering/src/components/InstagramBlockComponent.importable.tsx#L44), [UnsafeEmbedBlockComponent](https://github.com/guardian/dotcom-rendering/blob/cfb471804222b2b617609bff97386a9eceb59922/dotcom-rendering/src/components/UnsafeEmbedBlockComponent.importable.tsx#L57), [emailEmbed](https://github.com/guardian/frontend/blob/187ccbdb344a341739259ad79723d19c7f44419e/common/app/views/emailEmbed.scala.html#L37)), mainly to allow iframes to ask the parent doc to resize them. It has not been updated in 10 years, and...