ShouheiNishi

Results 15 comments of ShouheiNishi

Test code is https://github.com/ShouheiNishi/oapi-codegen/commit/19373ab96086a7d8c6cec20059c918fb2e42db54.

Test code is https://github.com/ShouheiNishi/oapi-codegen/tree/2037fbb269b13ce052aa8c7a803a68c2178d44de/internal/test/issues/issue-1452. ``` $ git status HEAD detached at 2037fbb nothing to commit, working tree clean $ (cd internal/test ; go generate ./issues/issue-1452/...) error generating code: error formatting...

Presumably, in the case of nullable and required properties, JSON null is more likely to satisfy the schema than zero value. Therefore, wouldn't it be better if JSON null was...

> @ShouheiNishi @bartsmykla mind checking if the changes in #1389 have solved this for you? No. We plan to summarize the problems that exist after the fix.

> To confirm, the fix from #1389 hasn't solved all the external reference issues you're affected by? Yes.

> What about #1253 that had this issue as a requirement? PR#1253 adds type conversion. In some of the test codes, the process of getting the destination type does not...

> To confirm, the fix from #1389 hasn't solved all the external reference issues you're affected by? At least there are still issues like the test cases in this pull...

> Mind seeing if #1387 fixes this for you? No, it seems that PR#1387 does not fix issue #1405. ``` $ git log -n 2 HEAD commit f13fbc6f08d59cfba607b8243b8703457115f9a4 (HEAD) Merge:...

Test code is https://github.com/ShouheiNishi/oapi-codegen/tree/9a8e5274f5a10f05caba603932510c9d471cdb70/internal/test/strict-server-response ``` $ git status HEAD detached at 9a8e527 nothing to commit, working tree clean $ (cd internal/test ; go generate ./strict-server-response/... && go test ./stri ct-server-response/...)...

We currently create a fix. But not sure if you need the ability to determine whether a value such as the following is an integer. | value string | is...