shopify_python
shopify_python copied to clipboard
Shopify
Python development standards at Shopify
`TestGoogleStyleGuideChecker` has a lot of tests and should be split up into separate suites so that we can lower the `pylintrc` `max-public-methods` setting back to 20.
Disabling a linter message doesn't disable the check for such a linter rule. If such a linter rule check throws an exception because it wasn't well tested, then the entire...
I just encountered a bug due to a trailing comma: i.e, in my coda I had ``` FOO = 42, ``` instead of ``` FOO = 42 ``` It interpreted...
Missing Google Style Guide rules that are not already covered by pylint include: - [ ] Use simple generators (list comprehensions **in-progress** https://github.com/Shopify/shopify_python/pull/30; limit complexity) [[link]](https://google.github.io/styleguide/pyguide.html?showone=List_Comprehensions#List_Comprehensions) - [ ] _Use...
We have Python projects that don't use these standards, and if they're large then they'll have some difficulty adopting them. Let's add a section detailing how to gradually adopt these...
When a function declaration uses type hints and needs to break across lines to stay within the character limit, we should have one parameter per line. e.g. ``` def foo(self,...
A variety of our projects use different pylintrc settings at the moment, but we should define one that they should all eventually converge to.