shopify_python
shopify_python copied to clipboard
Shopify
Python development standards at Shopify
Problem summary: Currently [shopify_python requires pylint ~= 2.1.1](https://github.com/Shopify/shopify_python/blob/v0.5.2/setup.py#L46). But, `pylint` v2.1.* has this dependency issue on `'isort >= 4.2.5`. There's no dependency constraint there, so eventually `isort` released `v5`. [pylint...
I'm trying to set up a brand new Python based project, and have a minimal dev environment right now, just Python 3.8.4 and pip. After adding this to my `requirements.txt`:...
I'm opening this issue because https://github.com/shopify/panama python client depends on `shopify_python` and there's a dependency issue on `pylint v2.1.1` that I think needs to be fixed here Currently [shopify_python requires...
__Description__ We've previously fixed the version of `pylint` to `1.7.1` (https://github.com/Shopify/shopify_python/pull/69) cause it seems there was an issue with `astroid` >= 1.6.0`. This doesn't seems to be the case anymore...
__Description__ Sometime your changes should not be compared with master but with a specific branch. This PR let you compare your changes with any branch, `master` by default.
When defining class methods, we can hint that a function is protected by prefacing it with `_` or we can invoke name-mangling by prefacing it with `__`. When there isn't...
@cfournie PTAL --- This change is [](https://reviewable.io/reviews/shopify/shopify_python/88)
the parameter may be nil, and the function should return 0 for that case.
@cfournie PTAL. Solves the following: ``` [2017-06-03T04:28:19Z] File "/app/.tox/pylint/src/pylint/pylint/utils.py", line 970, in walk [2017-06-03T04:28:19Z] cb(astroid) [2017-06-03T04:28:19Z] File "/app/.tox/pylint/lib/python3.5/site-packages/shopify_python/google_styleguide.py", line 145, in visit_lambda [2017-06-03T04:28:19Z] self.__lambda_func(node) [2017-06-03T04:28:19Z] File "/app/.tox/pylint/lib/python3.5/site-packages/shopify_python/google_styleguide.py", line 298, in...